Wireshark-commits: [Wireshark-commits] master-2.4 b421f91: When looking up response codes, just kee

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 09 Mar 2018 02:03:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b421f911d045add04cfae81adac29843e68624a5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

b421f91 by Guy Harris (guy@xxxxxxxxxxxx):

    When looking up response codes, just keep the key on the stack.
    
    We don't need to dynamically allocate a guint variable to hold the
    response code value - and then not bother to free it! - if we're just
    doing a lookup; we can use an automatic variable and pass a pointer to
    it.
    
    Change-Id: I6edbb352f0aa33c91ede0f4e1bbb962fa921bea2
    Reviewed-on: https://code.wireshark.org/review/26375
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 7ffc4f96ebe2fac503cb251a848441ad8d4bad8c)
    Reviewed-on: https://code.wireshark.org/review/26376
    

Actions performed:

    from  af63f57   S1AP: EmergencyAreaIDListForRestart is not an extension IE.
    adds  b421f91   When looking up response codes, just keep the key on the stack.


Summary of changes:
 ui/cli/tap-sipstat.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)