Wireshark-commits: [Wireshark-commits] master 9a5217b: Fix another leak, which happens with -E occu

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 07 Mar 2018 08:51:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a5217bdd4680e36f2e92838348bd4ea010d28a0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9a5217b by Guy Harris (guy@xxxxxxxxxxxx):

    Fix another leak, which happens with -E occurrence=l.
    
    For each occurrence, if there was already an occurrence in the array, we
    were just removing it. not freeing what it pointed to.
    
    While we're at it, expand comments. and always check the array size with
    "!= 0", not "> 0" - the value is unsigned, so they're equivalent, but
    this makes the code more self-consistent.
    
    Change-Id: I538f46b296a7721a39ba4366c2f6269e7e097b0d
    Reviewed-on: https://code.wireshark.org/review/26328
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3772396   WIP:ieee80211: HotSpot 2.0 fixes.
    adds  9a5217b   Fix another leak, which happens with -E occurrence=l.


Summary of changes:
 epan/print.c | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)