Wireshark-commits: [Wireshark-commits] master dd21b81: IEEE 802.15.4: always allocate protocol data

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 05 Mar 2018 01:56:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd21b8130c6470d2d5076fcc46d5e9c3866f4609
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dd21b81 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    IEEE 802.15.4: always allocate protocol data if not present
    
    When using 2 passes, L2TP dissector can set a session info for previous
    packets, breaking the assumption that IEEE 802.15.4 dissector will
    always be called on first pass.
    Let's always allocate the protocol data if missing, even if this is not
    the first pass.
    
    Bug: 14468
    Change-Id: I4cb7ea2e54c1b763a48b99c0d64f542552789d18
    Reviewed-on: https://code.wireshark.org/review/26260
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  cde7cc5   NBAP: avoid linking a DCH-ID to itself
    adds  dd21b81   IEEE 802.15.4: always allocate protocol data if not present


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)