Wireshark-commits: [Wireshark-commits] master cf373df: coloring rules dialogue: remove unused signa

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Mar 2018 11:34:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf373df7963d9ed6afee8285e2e1633ff6f7d93f
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cf373df by Martin Kaiser (wireshark@xxxxxxxxx):

    coloring rules dialogue: remove unused signal
    
    View / Coloring Rules...
    
    shows this warning
    
    12:02:26.401     Main Warn QObject::connect: No such signal ColoringRulesModel::dragDropComplete() in ../ui/qt/coloring_rules_dialog.cpp:61
    12:02:26.401     Main Warn QObject::connect:  (receiver name: 'ColoringRulesDialog')
    
    Remove the unused signal.
    
    Change-Id: Id42c249ac9252269eb31e4971e62e927a28c88ed
    Reviewed-on: https://code.wireshark.org/review/26239
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  5b07929   Windows: Remove support for MSVC older than VS2015
    adds  cf373df   coloring rules dialogue: remove unused signal


Summary of changes:
 ui/qt/coloring_rules_dialog.cpp | 2 --
 1 file changed, 2 deletions(-)