Wireshark-commits: [Wireshark-commits] master-2.2 8569f0b: Bugfix bad checksum of ICMP extension he

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 13 Apr 2017 11:21:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8569f0b2808551d5348e171ca7591227f27a4d50
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8569f0b by Michael Mann (mmann78@xxxxxxxxxxxx):

    Bugfix bad checksum of ICMP extension header.
    
    Use offset in tvb, not 0 for computation.
    Also add check for checksum = 0, which means checksum isn't present.
    
    # Conflicts:
    #	epan/dissectors/packet-icmp.c
    
    Bug: 13586
    Change-Id: I18812894104c35e50ecb99aa8eca6b030c78c486
    Reviewed-on: https://code.wireshark.org/review/21072
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4ca3155   packet-icmp.c: Remove tree check that prevents expert info
    adds  8569f0b   Bugfix bad checksum of ICMP extension header.


Summary of changes:
 epan/dissectors/packet-icmp.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)