URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75d40599b04d69a0857418ac7b7adac1266420dc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
75d4059 by Guy Harris (guy@xxxxxxxxxxxx):
No need to include <epan/packet.h> in <epan/ftypes/ftypes-int.h>.
It's sufficient to include <epan/proto.h>...
...as long as <epan/proto.h> includes <epan/tfs.h>, just as it includes
<epan/value_string.h>.
And, since it's already including <epan/value_string.h>, it doesn't need
to have a definition of struct _value_string as an incomplete type,
given that <epan/value_string.h> gives a definition of it as a complete
type.
Change-Id: Ic296bc0b0d68277ba7e0569412b780fd847ecca2
Reviewed-on: https://code.wireshark.org/review/21033
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from c6fb9ee Add -Wduplicated-branches to extra warnings
adds 75d4059 No need to include <epan/packet.h> in <epan/ftypes/ftypes-int.h>.
Summary of changes:
epan/ftypes/ftypes-int.h | 2 +-
epan/proto.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)