Wireshark-commits: [Wireshark-commits] master-2.2 7fa6f59: Provide better error messages for field

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Apr 2017 02:45:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fa6f59f840b5dd6644205a3efba8b7a8a280233
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7fa6f59 by Guy Harris (guy@xxxxxxxxxxxx):

    Provide better error messages for field type mismatches.
    
    Don't just report an assertion failure with a line in proto.c; give the
    name of the field with the wrong type, and a list of the types that are
    valid for the routine in question.
    
    Change-Id: Id3ed7c376fdc72bf6cff69c647833946cfa99ee6
    Reviewed-on: https://code.wireshark.org/review/20824
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 19bb1b128b0e8fdbff0959a00ea062a34fbadfb4)
    Reviewed-on: https://code.wireshark.org/review/20825
    

Actions performed:

    from  14f5f90   packet-ieee802154.c: Bugfix handling Auxilary Security Header for v2003
    adds  7fa6f59   Provide better error messages for field type mismatches.


Summary of changes:
 epan/proto.c |   24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)