URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17a3730146e56b7aee0f15dbcc6b6106a7bc4e82
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark
Commits:
17a3730 by Peter Wu (peter@xxxxxxxxxxxxx):
dns: prevent repeatedly overwriting resolved entries
When a packet contains multiple conflicting names for the same address,
it would result in modification of the resolved name every time this DNS
packet is selected. In Qt, this causes a periodic (one second)
redissection of the current (DNS!) packet which interferes with user
interaction. To avoid this, only add the address on the first visit.
Bug: 13533
Change-Id: Ic71515131da4d666bfd589df9ff90a866a30778c
Reviewed-on: https://code.wireshark.org/review/20800
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 93cf5909ec0aabb84b96c518ad61e082d52600b6)
Reviewed-on: https://code.wireshark.org/review/20805
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from c9beee0 Print signed values with %d, not %u.
adds 17a3730 dns: prevent repeatedly overwriting resolved entries
Summary of changes:
epan/dissectors/packet-dns.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)