URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb017f3eb30804645a84ccc4cd071fac44d0a326
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
bb017f3 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):
androiddump: Fix tcpdump op prec bug with used_buffer_length calc
androiddump reads data from tcpdump in chunks that not necessarily
match packet sizes. Whenever a partly read packet is found in buffers
more data is read and the number of used bytes in buffer is updated.
The calculation of used_buffer_length is wrong though leading to most
packets are read and thrown away.
Problem fixed by correcting an operator precedence mistake where
used_buffer_length would only be increaded with 0 or 1 insted of
actual number of read bytes.
Change-Id: Ib5c4e1d96e7ba499f26796ffa5d7ce6a116b9a6e
Reviewed-on: https://code.wireshark.org/review/20666
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from c9bf21c umts_fp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
adds bb017f3 androiddump: Fix tcpdump op prec bug with used_buffer_length calc
Summary of changes:
extcap/androiddump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)