Wireshark-commits: [Wireshark-commits] master 16c8bff: Catch read errors and zero-length records, a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Mar 2017 18:48:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16c8bff15ad20e1a4c11e116ff29f36f527ffded
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

16c8bff by Guy Harris (guy@xxxxxxxxxxxx):

    Catch read errors and zero-length records, as opposed to short reads/EOF.
    
    Also, if we return WTAP_OPEN_ERROR from an open routine after we've set
    our close routine, that routine is called, which frees up our private
    data structures; don't free them ourselves before returning
    WTAP_OPEN_ERROR.
    
    Change-Id: I03eebe1a1677e2161fdacec8de14668093cf03a3
    Reviewed-on: https://code.wireshark.org/review/20522
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  10798ef   ftypes (trivial): fix two comments
    adds  16c8bff   Catch read errors and zero-length records, as opposed to short reads/EOF.


Summary of changes:
 wiretap/netscaler.c |   72 +++++++++++++++++++++++++++++++++++----------------
 1 file changed, 50 insertions(+), 22 deletions(-)