URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8020c7f6253ae606736326b41e572630c73ee59
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c8020c7 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):
ansi_a: fix this condition has identical branches [-Werror=duplicated-branches] found by gcc7
All users of the ELEM_OPT_TLV and ELEM_MAND_TV macros pass an empty string ("")
for the elem_name_addition parameter, so it can never be NULL. The Coverity
warning was about a superfluous check (elem_name_addition[0]=='\0'). All of
these checks are superfluous anyway since both branches yield an empty string.
Change-Id: I28c994fd5e10c04f99c8d77e9aee18afd4a26412
Reviewed-on: https://code.wireshark.org/review/20427
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from ae39d9a tshark and tfshark require -2 when using -R. Document this.
adds c8020c7 ansi_a: fix this condition has identical branches [-Werror=duplicated-branches] found by gcc7
Summary of changes:
epan/dissectors/packet-ansi_a.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)