Wireshark-commits: [Wireshark-commits] master-2.2 ef332b8: Qt: Fix heap-use-after-free when deletin

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Mar 2017 09:27:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef332b8bfacf97364ba40ab9bb07be30dc67e916
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ef332b8 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix heap-use-after-free when deleting IO graph
    
    Deleting a IO graph item while editing a field will use the IOGraph
    object so ensure we delete in correct order to avoid heap-use-after-free.
    
    Bug: 13234
    Change-Id: I6d0de21684f842fbd67c9b38fc6b75b81aec5518
    Reviewed-on: https://code.wireshark.org/review/20456
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit e781fdd18010c6c70d08b1bd89cd3449d4a5b14d)
    Reviewed-on: https://code.wireshark.org/review/20458
    

Actions performed:

    from  173be1a   imap: Give correct lineend to get_token_len()
    adds  ef332b8   Qt: Fix heap-use-after-free when deleting IO graph


Summary of changes:
 ui/qt/io_graph_dialog.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)