Wireshark-commits: [Wireshark-commits] master-2.2 7ccb41e: http: Check for valid tcpinfo pointer

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Mar 2017 09:55:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ccb41ede2ee674f82f3f734dce64e7a8abaa897
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7ccb41e by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    http: Check for valid tcpinfo pointer
    
    In dissect_http_tcp() the data pointer may be NULL so ensure
    we check for this before dereferencing it.
    
    Bug: 13457
    Change-Id: I84f4a0e3b416a2829998f20fe59da8770a34e564
    Reviewed-on: https://code.wireshark.org/review/20438
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit af8361a90e514b2773202bc602fb223c8426ca70)
    Reviewed-on: https://code.wireshark.org/review/20449
    

Actions performed:

    from  adbe2f5   Don't close the pcap_t in get_data_link_types().
    adds  7ccb41e   http: Check for valid tcpinfo pointer


Summary of changes:
 epan/dissectors/packet-http.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)