Wireshark-commits: [Wireshark-commits] master-2.2 7018427: Make sure nspr_getv20recordsize() return

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Mar 2017 22:54:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=70184273adf44f2fa69bed7486afdfbc108904c7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7018427 by Guy Harris (guy@xxxxxxxxxxxx):

    Make sure nspr_getv20recordsize() returns an unsigned value.
    
    The record size fields are guint8, but NSPR_V20RECORDSIZE_2BYTES was
    0x80, which has type int, promoting the result to int.  Make it 0x80U,
    which means everything is unsigned.
    
    This squelches a compiler warning.
    
    Change-Id: I1c63e485352a90c7f675ab0dacaaeba794235b35
    Reviewed-on: https://code.wireshark.org/review/20344
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b98bb5188c9082a06a370483c9474a929e957659)
    Reviewed-on: https://code.wireshark.org/review/20345
    

Actions performed:

    from  37bbc14   Add more sanity checks.
    adds  7018427   Make sure nspr_getv20recordsize() returns an unsigned value.


Summary of changes:
 wiretap/netscaler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)