Wireshark-commits: [Wireshark-commits] master-2.2 d00ced1: Do more record length checks.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Mar 2017 09:03:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d00ced1548c914802a033d328f0b79d60ccd50c3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d00ced1 by Guy Harris (guy@xxxxxxxxxxxx):

    Do more record length checks.
    
    Do the check early in the process of processing the record, and do it
    for all record types.
    
    Bug: 13429
    Change-Id: Id7f4d12415c6740241850d8f873cff52909e7110
    Reviewed-on: https://code.wireshark.org/review/20330
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit e4dfeed2ca2491fa944dc9cd5180ec202313b5b6)
    Reviewed-on: https://code.wireshark.org/review/20331
    

Actions performed:

    from  7eb76d2   Don't go past the end of a page in a NetScaler file.
    adds  d00ced1   Do more record length checks.


Summary of changes:
 wiretap/netscaler.c |   60 ++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 45 insertions(+), 15 deletions(-)