URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d464d9cb5c94003f2a0938ab05d6a184dc2a8b94
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
d464d9c by Peter Wu (peter@xxxxxxxxxxxxx):
Revert "Qt: call cleanup from destructor in WiresharkApplication."
Calling cleanup() twice (via exit signal and via destructor) results in a
use-after-free on exit via write_profile_recent.
This reverts commit e47f9fbeb090a68f9229b0f03c3f76a6285d2dff.
Change-Id: Ic3ca0742c03a345fd8cb7f3f782942872a3057f5
Reviewed-on: https://code.wireshark.org/review/20273
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from cd7d159 json2pcap support added
adds d464d9c Revert "Qt: call cleanup from destructor in WiresharkApplication."
Summary of changes:
ui/qt/wireshark_application.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)