Wireshark-commits: [Wireshark-commits] master 7d83068: user_encap: Don't allocate duplicate strings

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Feb 2017 04:55:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d8306829b7253aa4c6a6067d7062a7fc368a358
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7d83068 by Dario Lombardo (lomato@xxxxxxxxx):

    user_encap: Don't allocate duplicate strings for user_encap2
    
    All is does is lead to memory leaks.
    
    Change-Id: Ia20b95c9a7ae36df5b902cf59b33fbd046c2da56
    Reviewed-on: https://code.wireshark.org/review/20076
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5d3d96c   transum: Add protections against NULL trees.
    adds  7d83068   user_encap: Don't allocate duplicate strings for user_encap2


Summary of changes:
 epan/dissectors/packet-user_encap.c |   15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)