Wireshark-commits: [Wireshark-commits] master 6b84dde: Make Libgcrypt a mandatory dependency

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Feb 2017 18:36:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b84ddee83e70aff944da084129624226b7a32fa
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6b84dde by Peter Wu (peter@xxxxxxxxxxxxx):

    Make Libgcrypt a mandatory dependency
    
    Removed all guards for HAVE_LIBGCRYPT, change autotools and CMake to
    error out if it is not available. Update release notes, developer
    documentation and README with the new status. Clarify relation with
    GnuTLS in macosx-setup.sh. Install Libgcrypt via brew script.
    
    Motivation for this change is that many dissectors depend on Libgcrypt
    and having it optional increases the maintenance burden (there have been
    several compile issues in the past due to the optional status).
    Furthermore, wsutil has crypto code that can be replaced by Libgcrypt.
    
    Change-Id: Idf0021b8c4cd5db70b8766f7dcc2a8b3acbf042f
    Link: https://www.wireshark.org/lists/wireshark-dev/201702/msg00011.html
    Reviewed-on: https://code.wireshark.org/review/20030
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  b5610a0   [ISAKMP] Dissect 3GPP private error and status messages in NOTIFY.
    adds  6b84dde   Make Libgcrypt a mandatory dependency


Summary of changes:
 CMakeLists.txt                                     |   24 ++--
 CMakeOptions.txt                                   |    1 -
 capinfos.c                                         |   35 +-----
 cmakeconfig.h.in                                   |    3 -
 configure.ac                                       |   35 +-----
 doc/README.developer                               |    7 +-
 docbook/release-notes.asciidoc                     |    1 +
 docbook/wsdg_src/WSDG_chapter_libraries.asciidoc   |    7 +-
 epan/dissectors/asn1/c1222/c1222.cnf               |    2 -
 epan/dissectors/asn1/c1222/packet-c1222-template.c |   33 ------
 .../asn1/pkcs12/packet-pkcs12-template.c           |   10 --
 epan/dissectors/asn1/snmp/packet-snmp-template.c   |   30 +----
 epan/dissectors/packet-c1222.c                     |   43 +-------
 epan/dissectors/packet-dof.c                       |    4 +-
 epan/dissectors/packet-dtls.c                      |   10 +-
 epan/dissectors/packet-dvbci.c                     |   18 ---
 epan/dissectors/packet-ieee802154.c                |   17 ---
 epan/dissectors/packet-ipsec.c                     |   30 -----
 epan/dissectors/packet-isakmp.c                    |  105 +-----------------
 epan/dissectors/packet-lwm.c                       |   10 --
 epan/dissectors/packet-pdcp-lte.c                  |   11 +-
 epan/dissectors/packet-pkcs12.c                    |   18 +--
 epan/dissectors/packet-smb2.c                      |   16 +--
 epan/dissectors/packet-snmp.c                      |   36 ++----
 epan/dissectors/packet-ssl-utils.c                 |  115 +++-----------------
 epan/dissectors/packet-ssl-utils.h                 |   25 +----
 epan/dissectors/packet-ssl.c                       |    8 +-
 epan/dissectors/packet-zbee-security.c             |   26 -----
 epan/epan.c                                        |   21 +---
 macosx-setup.sh                                    |   12 +-
 tools/macos-setup-brew.sh                          |    2 +-
 wsutil/eax.c                                       |    2 -
 wsutil/wsgcrypt.h                                  |    4 -
 33 files changed, 90 insertions(+), 631 deletions(-)