URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea0a7f211ce5d503de6a46502f98c80cec205d7e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
ea0a7f2 by Diederik de Groot (dkgroot@xxxxxxxx):
[skinny]: Add struct/union guards to multi-part message handlers
Improve multi-part message handling
- Calculate (sub) structure/union length
- Add a guard when iterating over multi-part message
- For fixed length messages, advance the cursor when iteration falls short of max length
Change-Id: Id2af3aa1a878328f105e173cabe2b68dd0343507
Reviewed-on: https://code.wireshark.org/review/20057
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from fb3a7ca [skinny] Fix ConnectionStatRes and DialedNumber Messages protocol version >20
adds ea0a7f2 [skinny]: Add struct/union guards to multi-part message handlers
Summary of changes:
epan/dissectors/packet-skinny.c | 1912 +++++++++++++++--------------------
epan/dissectors/packet-skinny.c.in | 11 +-
epan/dissectors/packet-skinny.h | 11 +-
epan/dissectors/packet-skinny.h.in | 11 +-
tools/parse_xml2skinny_dissector.py | 107 +-
5 files changed, 948 insertions(+), 1104 deletions(-)