Wireshark-commits: [Wireshark-commits] master 746bbe7: ssl-utils: add length validation for Certifi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Feb 2017 10:48:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=746bbe7abf4bad74b78db0282d8962eb891eb502
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

746bbe7 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: add length validation for Certificate handshake message
    
    This also introduces a new macro, "G_MAXUINT24" as symbol for 2^24-1
    (this name does not exist in GLib and uncommon in Google).
    
    Change-Id: If000f41f6286161e3a7697357fc33ae16c1e11db
    Reviewed-on: https://code.wireshark.org/review/20003
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  b659c76   TLS13: fix length of Finished message
    adds  746bbe7   ssl-utils: add length validation for Certificate handshake message


Summary of changes:
 epan/dissectors/packet-dtls.c      |    2 +-
 epan/dissectors/packet-ssl-utils.c |   43 +++++++++++++++++++++++-------------
 epan/dissectors/packet-ssl-utils.h |    5 ++++-
 epan/dissectors/packet-ssl.c       |    2 +-
 4 files changed, 34 insertions(+), 18 deletions(-)