Wireshark-commits: [Wireshark-commits] master 8136258: ssl-utils: add length validation to Certific

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Feb 2017 00:10:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=813625883c109cd0fce3257872faa4a87dcfae55
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8136258 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: add length validation to CertificateRequest
    
    Add length validation to several fields in CertificateRequest. Clarify
    specification, remove unnecessary length check and add TODO for TLS 1.3.
    
    Change-Id: Ic3aca62d90e5fad6930beb371adf10d7b7b9fbe2
    Reviewed-on: https://code.wireshark.org/review/20010
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0e08518   TLS13: add length validation for Pre-Shared Key Exchange Modes
    adds  8136258   ssl-utils: add length validation to CertificateRequest


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   76 +++++++++++++++++++-----------------
 1 file changed, 41 insertions(+), 35 deletions(-)