Wireshark-commits: [Wireshark-commits] master efed7b5: ssl-utils: stylistic changes for ServerHello

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Feb 2017 23:46:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=efed7b5ab6bb0f3a6ca8a2368964df3a3917ee85
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

efed7b5 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: stylistic changes for ServerHello, HelloRetryRequest
    
    Change "length" to "offset_end" parameter for consistency. Clarify
    applicable TLS version in comments. Remove unnecessary check for length.
    
    Change-Id: Icdc7edff9c8fdaf4c7d7349f65fed42f5344f2c3
    Reviewed-on: https://code.wireshark.org/review/20001
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  d13da6c   diameter_3gpp: added decoding of TWAN-Identifier AVP
    adds  efed7b5   ssl-utils: stylistic changes for ServerHello, HelloRetryRequest


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   28 ++++++++++++----------------
 epan/dissectors/packet-ssl-utils.h |    4 ++--
 epan/dissectors/packet-ssl.c       |    4 ++--
 3 files changed, 16 insertions(+), 20 deletions(-)