URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b18245a60c5dc3532d144699dd00f36d84c4e176
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
b18245a by Noel Power (noel.power@xxxxxxxx):
mswsp: Numerous bugfixes
1. Fix display of CTableColumn.StatusUsed & CTableColumn.LengthUsed
Both StatusUsed and LenghtUsed members were displayed as 2 byte length
values instead of single byte values.
2. Fix minor spelling mistake
3. display correct address(s) for array of address values
4. Use correct minimum CTableColumn size
This is followup patch for patch already provided for bug 13299.
The previous minimum value neglated to take into account the
CFullPropSpec structure (which is on the wire) but is represtented
as a string in the internal CTableColumn structure. Note: this doesn't
make any difference to the effectiveness of the previous patch but should
avoid confusion if someone later actually investigates the correct minimum
size.
5. Fix CPMCREATEQUERY message parsing
Following a query and subsequent clarification from dochelp@xxxxxxxxxxxxx
the MS-WSP specification document was found to be incorrect.
CPMCreateQueryIn
|
---> CSortSet
should instead eventually point to CSortSet via the following msg structure
CPMCreateQueryIn
|
---> CInGroupSortAggregSets
|
---> CInGroupSortAggregSet
|
---> CSortSet
Change-Id: I7da6c7db817113f5542f25f078626030ad30d737
Signed-off-by: Noel Power <noel.power@xxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/20031
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from e0fafa5 Convert conversation data_list from GSList to wmem_tree.
adds b18245a mswsp: Numerous bugfixes
Summary of changes:
epan/dissectors/packet-mswsp.c | 31 +++++++++++--------------------
1 file changed, 11 insertions(+), 20 deletions(-)