Wireshark-commits: [Wireshark-commits] master c5adada: TLS13: fix CertificateVerify dissection for

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Jan 2017 14:52:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5adada79e1b10154b22c32b243bb3140bc903d8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c5adada by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS13: fix CertificateVerify dissection for -18
    
    digitally-signed is gone in TLS 1.3. ClientKeyExchange/ServerKeyExchange
    are gone, so effectively modifying this function is good enough to cover
    CertificateVerify dissection (ssl_dissect_hnd_cli_cert_verify).
    
    See https://tools.ietf.org/html/draft-ietf-tls-tls13-18#page-58
    
    Change-Id: I07f621bc088d810a3f35343bec7a0a3303b1426b
    Ping-Bug: 12779
    Reviewed-on: https://code.wireshark.org/review/19866
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ec38330   Support for NSH with Ethernet encapsulation
    adds  c5adada   TLS13: fix CertificateVerify dissection for -18


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    1 +
 1 file changed, 1 insertion(+)