Wireshark-commits: [Wireshark-commits] master bd86a45: Dumpcap: Improve an error message.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 30 Jan 2017 23:56:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd86a45006c20bcce4e5754fc575363ab7b33f66
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bd86a45 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Dumpcap: Improve an error message.
    
    Dumpcap doesn't yet support capturing pcapng from stdin. On Windows,
    make sure we invalidate our file handle so that instead of printing
    
      "Error reading from pipe: The operation completed successfully. (error 0)"
    
    we show the more useful
    
      "Capturing from a pipe doesn't support pcapng format."
    
    Change-Id: I472c1bf5c8520c9ee3fe4b6299a6e0250262ea51
    Reviewed-on: https://code.wireshark.org/review/19876
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d5b053d   Qt: Use system DateTimeFormat in QDateTimeEdit
    adds  bd86a45   Dumpcap: Improve an error message.


Summary of changes:
 dumpcap.c |    3 +++
 1 file changed, 3 insertions(+)