Wireshark-commits: [Wireshark-commits] master 57894f7: DHCPv6: Avoid integer overflows.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Jan 2017 19:22:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57894f741f7cc98b46c9fdce7eee8256d2a4ae3f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

57894f7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    DHCPv6: Avoid integer overflows.
    
    Count using ints instead of guint16s.
    
    Make sure dissect_packetcable_ccc_option and
    dissect_packetcable_cccV6_option return positive values while we're
    here.
    
    Bug: 13345
    Change-Id: Ic303ddc266f46ee3144e079731742c85808faf37
    Reviewed-on: https://code.wireshark.org/review/19747
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9cece7c   GTK+: Yell at the user less.
    adds  57894f7   DHCPv6: Avoid integer overflows.


Summary of changes:
 epan/dissectors/packet-dhcpv6.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)