Wireshark-commits: [Wireshark-commits] master-2.2 be1d4be: Have a routine to do all the work of ini

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Jan 2017 12:31:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be1d4becb03087db748f7d486fa419858d70a042
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

be1d4be by Guy Harris (guy@xxxxxxxxxxxx):

    Have a routine to do all the work of initializing libwiretap.
    
    Have programs that use libwiretap call that routine rather than
    separately calling some or all of init_open_routines(),
    wtap_register_plugin_types(), and wtap_opttypes_initialize().
    
    Also don't have routines internal to libwiretap call those.  Yes, this
    means doing some initialization work when it isn't necessary, but
    scattering on-demand calls throughout the code is a great way to forget
    to make those calls.
    
    Change-Id: I5828e1c5591c9d94fbb3eb0a0e54591e8fc61710
    Reviewed-on: https://code.wireshark.org/review/19069
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit ab07f8e0f89eb1bb2c2c61c71e44e3fd0e31cc52)
    Reviewed-on: https://code.wireshark.org/review/19705
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  ad406f8   Add a missing item to the release notes.
    adds  be1d4be   Have a routine to do all the work of initializing libwiretap.


Summary of changes:
 capinfos.c                  |    6 ++----
 captype.c                   |    6 ++----
 editcap.c                   |    6 ++----
 extcap/androiddump.c        |    3 +--
 mergecap.c                  |    6 ++----
 randpkt.c                   |   14 ++++++--------
 randpkt_core/randpkt_core.c |    2 +-
 reordercap.c                |    6 ++----
 tfshark.c                   |    2 +-
 tshark.c                    |    3 +--
 ui/gtk/main.c               |    3 +--
 wireshark-qt.cpp            |    3 +--
 wiretap/file_access.c       |    7 -------
 wiretap/wtap.c              |   19 ++++++++++++++-----
 wiretap/wtap.h              |    4 ++++
 15 files changed, 40 insertions(+), 50 deletions(-)