Wireshark-commits: [Wireshark-commits] master 069a532: LDAP: fix wrong use of g_strlcpy introduced

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jan 2017 00:28:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=069a5329887b9195f7994de00fe46c9fd055ca71
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

069a532 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    LDAP: fix wrong use of g_strlcpy introduced in gc397add
    
    Last parameter is the destination buffer size, not the number of bytes to copy.
    
    Bug: 13332
    Change-Id: I9a6f5231d2d7a94fd5e692e8bbf4f5dba30b7c1a
    Reviewed-on: https://code.wireshark.org/review/19677
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5df8d09   packet: clean shutdown routines.
    adds  069a532   LDAP: fix wrong use of g_strlcpy introduced in gc397add


Summary of changes:
 epan/dissectors/asn1/ldap/packet-ldap-template.c |    2 +-
 epan/dissectors/packet-ldap.c                    |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)