Wireshark-commits: [Wireshark-commits] master 7cd6906: Rename tvb_new_subset() to tvb_new_subset_le

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Jan 2017 06:20:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7cd6906056922e4b8f68f1216d94eaa0809896fe
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7cd6906 by Guy Harris (guy@xxxxxxxxxxxx):

    Rename tvb_new_subset() to tvb_new_subset_length_caplen().
    
    This emphasizes that there is no such thing as *the* routine to
    construct a subset tvbuff; you need to choose one of
    tvb_new_subset_remaining() (if you want a new tvbuff that contains
    everything past a certain point in an existing tvbuff),
    tvb_new_subset_length() (if you want a subset that contains everything
    past a certain point, for some number of bytes, in an existing tvbuff),
    and tvb_new_subset_length_caplen() (for all other cases).
    
    Many of the calls to tvb_new_subset_length_caplen() should really be
    calling one of the other routines; that's the next step.  (This also
    makes it easier to find the calls that need fixing.)
    
    Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b
    Reviewed-on: https://code.wireshark.org/review/19597
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2a3b236   ieee80211: Add Extreme (Zebra) Vendor Specific TLV
    adds  7cd6906   Rename tvb_new_subset() to tvb_new_subset_length_caplen().


Summary of changes:
 debian/libwireshark0.symbols                       |    2 +-
 doc/README.dissector                               |    2 +-
 docbook/wsdg_src/WSDG_chapter_dissection.asciidoc  |    4 +-
 epan/dissectors/asn1/cmp/packet-cmp-template.c     |    6 +-
 epan/dissectors/asn1/h225/h225.cnf                 |    2 +-
 epan/dissectors/asn1/h245/h245.cnf                 |    4 +-
 .../asn1/kerberos/packet-kerberos-template.c       |    2 +-
 epan/dissectors/asn1/ldap/packet-ldap-template.c   |    6 +-
 .../asn1/mpeg-pes/packet-mpeg-pes-template.c       |    2 +-
 epan/dissectors/asn1/ros/ros-err.cnf               |    2 +-
 epan/dissectors/asn1/ros/ros-inv.cnf               |    2 +-
 epan/dissectors/asn1/ros/ros-res.cnf               |    2 +-
 .../asn1/spnego/packet-spnego-template.c           |    2 +-
 epan/dissectors/file-btsnoop.c                     |    6 +-
 epan/dissectors/file-pcap.c                        |    2 +-
 epan/dissectors/file-pcapng.c                      |    4 +-
 epan/dissectors/packet-9p.c                        |    4 +-
 epan/dissectors/packet-adb.c                       |    2 +-
 epan/dissectors/packet-adb_cs.c                    |    4 +-
 epan/dissectors/packet-bgp.c                       |    2 +-
 epan/dissectors/packet-bluecom.c                   |    2 +-
 epan/dissectors/packet-brdwlk.c                    |    2 +-
 epan/dissectors/packet-btatt.c                     |   22 +++----
 epan/dissectors/packet-bthci_acl.c                 |    2 +-
 epan/dissectors/packet-btl2cap.c                   |   10 +--
 epan/dissectors/packet-bvlc.c                      |    2 +-
 epan/dissectors/packet-c15ch.c                     |   16 ++---
 epan/dissectors/packet-cmp.c                       |    6 +-
 epan/dissectors/packet-componentstatus.c           |    2 +-
 epan/dissectors/packet-corosync-totemnet.c         |    2 +-
 epan/dissectors/packet-couchbase.c                 |    8 +--
 epan/dissectors/packet-cp2179.c                    |    2 +-
 epan/dissectors/packet-cpfi.c                      |    4 +-
 epan/dissectors/packet-dcerpc-dnsserver.c          |    2 +-
 epan/dissectors/packet-dcerpc-eventlog.c           |    4 +-
 epan/dissectors/packet-dcerpc-frsrpc.c             |   30 ++++-----
 epan/dissectors/packet-dcerpc-krb5rpc.c            |    4 +-
 epan/dissectors/packet-dcerpc-lsa.c                |    2 +-
 epan/dissectors/packet-dcerpc-mapi.c               |    4 +-
 epan/dissectors/packet-dcerpc.c                    |   12 ++--
 epan/dissectors/packet-dcp-etsi.c                  |    4 +-
 epan/dissectors/packet-dlsw.c                      |    2 +-
 epan/dissectors/packet-dof.c                       |   58 ++++++++---------
 epan/dissectors/packet-e100.c                      |    2 +-
 epan/dissectors/packet-eap.c                       |    2 +-
 epan/dissectors/packet-eigrp.c                     |   18 +++---
 epan/dissectors/packet-epl.c                       |    2 +-
 epan/dissectors/packet-erldp.c                     |    2 +-
 epan/dissectors/packet-eth.c                       |    4 +-
 epan/dissectors/packet-ethertype.c                 |    2 +-
 epan/dissectors/packet-fcoe.c                      |    2 +-
 epan/dissectors/packet-fcp.c                       |    4 +-
 epan/dissectors/packet-fip.c                       |    4 +-
 epan/dissectors/packet-gsm_um.c                    |    2 +-
 epan/dissectors/packet-gtpv2.c                     |    2 +-
 epan/dissectors/packet-h223.c                      |    2 +-
 epan/dissectors/packet-h225.c                      |    2 +-
 epan/dissectors/packet-h245.c                      |    4 +-
 epan/dissectors/packet-h264.c                      |    8 +--
 epan/dissectors/packet-h450-ros.c                  |    6 +-
 epan/dissectors/packet-hiqnet.c                    |    2 +-
 epan/dissectors/packet-http.c                      |    4 +-
 epan/dissectors/packet-iec104.c                    |    2 +-
 epan/dissectors/packet-ieee80211.c                 |    8 +--
 epan/dissectors/packet-ieee802154.c                |   12 ++--
 epan/dissectors/packet-ieee8023.c                  |    2 +-
 epan/dissectors/packet-igrp.c                      |    6 +-
 epan/dissectors/packet-ipmi-session.c              |    2 +-
 epan/dissectors/packet-ipsec-tcp.c                 |    2 +-
 epan/dissectors/packet-ipsec.c                     |    2 +-
 epan/dissectors/packet-iscsi.c                     |   10 +--
 epan/dissectors/packet-isi.c                       |    2 +-
 epan/dissectors/packet-isl.c                       |    6 +-
 epan/dissectors/packet-iso15765.c                  |    4 +-
 epan/dissectors/packet-isup.c                      |   66 ++++++++++----------
 epan/dissectors/packet-kdsp.c                      |    2 +-
 epan/dissectors/packet-kerberos.c                  |    2 +-
 epan/dissectors/packet-kink.c                      |   10 +--
 epan/dissectors/packet-lapdm.c                     |    2 +-
 epan/dissectors/packet-lapsat.c                    |    2 +-
 epan/dissectors/packet-ldap.c                      |    6 +-
 epan/dissectors/packet-ldp.c                       |    2 +-
 epan/dissectors/packet-ltp.c                       |    2 +-
 epan/dissectors/packet-mbtcp.c                     |    2 +-
 epan/dissectors/packet-meta.c                      |    2 +-
 epan/dissectors/packet-mgcp.c                      |    6 +-
 epan/dissectors/packet-mpeg-pes.c                  |    2 +-
 epan/dissectors/packet-msdp.c                      |    2 +-
 epan/dissectors/packet-mstp.c                      |    2 +-
 epan/dissectors/packet-mtp2.c                      |    4 +-
 epan/dissectors/packet-nas_eps.c                   |    2 +-
 epan/dissectors/packet-nb_rtpmux.c                 |    2 +-
 epan/dissectors/packet-nbt.c                       |    2 +-
 epan/dissectors/packet-ncp.c                       |    4 +-
 epan/dissectors/packet-ncp2222.inc                 |    6 +-
... 77 lines suppressed ...