URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0acd5034ac07c5e6cbaf56b8975ab3779b410d8d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
0acd503 by Paul Williamson (paul@xxxxxxxxxxxxx):
Revert "Support all MA modes, fix BB CRC and frag edge cases"
Supporting all MA modes this way makes the dissector useless as a heuristic dissector; it always matches. I just didn't understand about heuristic dissectors, and will look for a better solution.
The fragmentation edge cases were also misunderstood. On closer reading of the spec, these are not valid edge cases to be handled smoothly, but packet formatting errors to be diagnosed.
The BB CRC fix is valid AFAIK, and will be resubmitted separately.
This reverts commit 2563503301aa4321a9a7a1ed392c9cbbe147fd2f.
Change-Id: I842f4eca59193b24f41a67ce7d081c681b70f449
Reviewed-on: https://code.wireshark.org/review/19449
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 2f09610 cms: don't assert if eContent fails to be dissected
adds 0acd503 Revert "Support all MA modes, fix BB CRC and frag edge cases"
Summary of changes:
epan/dissectors/packet-dvb-s2-bb.c | 260 ++++++++++++------------------------
1 file changed, 85 insertions(+), 175 deletions(-)