Wireshark-commits: [Wireshark-commits] master dd143ca: [SMTP] Bugfix BDAT command handling

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Dec 2016 13:21:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd143ca7681e2e3150904b764027e041927dcbf2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dd143ca by Michael Mann (mmann78@xxxxxxxxxxxx):

    [SMTP] Bugfix BDAT command handling
    
    BDAT handling takes the whole packet to add to its count of necessary
    bytes, but wasn't updating the offset, so if a BDAT "data packet" had
    multiple CRLF segments in it, the BDAT byte counter became inaccurate.
    
    Bug: 13030
    Change-Id: Idd44ccb95a8f4710db4546a918661c63a343260c
    Reviewed-on: https://code.wireshark.org/review/19343
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  36ec624   Added decoding of RAN/NAS cause IE/AVP
    adds  dd143ca   [SMTP] Bugfix BDAT command handling


Summary of changes:
 epan/dissectors/packet-smtp.c |    4 ++++
 1 file changed, 4 insertions(+)