Wireshark-commits: [Wireshark-commits] master 92a2c18: Revert "Don't use a local variable's address

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Dec 2016 22:51:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=92a2c184b09ce41a1ab717963750bb5543099742
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

92a2c18 by Guy Harris (guy@xxxxxxxxxxxx):

    Revert "Don't use a local variable's address in set_address()."
    
    This reverts commit e2c26ff90c6aee381c3af0c33253dcfa5631bb43.
    
    *That* address isn't attached to a pinfo structure, it's used to create a conversation, and a copy is made of it, using file scope.  So that's not the cause of this problem.
    
    Change-Id: I07ce091e678c42c30080cd00fd17cd1584f473ad
    Reviewed-on: https://code.wireshark.org/review/19138
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e2c26ff   Don't use a local variable's address in set_address().
    adds  92a2c18   Revert "Don't use a local variable's address in set_address()."


Summary of changes:
 epan/dissectors/packet-infiniband.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)