Wireshark-commits: [Wireshark-commits] master 451eac8: packet-rpcrdma: Prepare dissector for RPC-ov

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Dec 2016 01:32:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=451eac813745170074aa9223ab558263aa8f73f5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

451eac8 by Chuck Lever (chuck.lever@xxxxxxxxxx):

    packet-rpcrdma: Prepare dissector for RPC-over-RDMA on iWARP or RoCE
    
    Remove the Infiniband-centric QP filtering. This filtering attempted
    to create conversations to allow the heuristic dissector to be
    bypassed once it was established that a QP was carrying
    RPC-over-RDMA traffic.
    
    However, it was preventing proper identification of RPC-over-RDMA
    traffic when a CM connection establishment exchange doesn't appear
    in the capture (which is frequently the case for captures of NFS
    traffic).
    
    Also, without this conversation logic, loading a capture file
    appears to be significantly faster, at least for capture files
    I have on hand.
    
    Later, some form of conversation management will be needed in
    order to associate RPC-over-RDMA transport headers with
    RDMA Read and Write operations that go along with them. But it
    will need to be agnostic about the underlying link layer.
    
    Bug: 13199
    Bug: 13202
    Change-Id: Ie6b7a4c65979dac036306f7367ce18836713ab4d
    Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19032
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4f684a6   packet-tns: add TNS_TYPE_DATA functions dissection.
    adds  451eac8   packet-rpcrdma: Prepare dissector for RPC-over-RDMA on iWARP or RoCE


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |  221 ++++++++++++--------------------------
 1 file changed, 69 insertions(+), 152 deletions(-)