Wireshark-commits: [Wireshark-commits] master 7c3ecc6: DOF: fix UAT update callbacks

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Dec 2016 16:05:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c3ecc6956e456867ac7d216600ea3697b548eff
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7c3ecc6 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    DOF: fix UAT update callbacks
    
    - update callback must return a boolean to indicate success / failure
    - error message must be allcoated in glib memory as GUI will g_free it
    
    Bug: 13209
    Change-Id: Ibb9690034d66dae85e775d0010aadeb192c76b4a
    Reviewed-on: https://code.wireshark.org/review/19111
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e2c812c   Bluetooth: Sync "Classic" color rules
    adds  7c3ecc6   DOF: fix UAT update callbacks


Summary of changes:
 epan/dissectors/packet-dof.c |  141 +++++++++++++++++++++---------------------
 1 file changed, 72 insertions(+), 69 deletions(-)