Wireshark-commits: [Wireshark-commits] master-2.2 3508aee: SMB: Limit Export object files to 32 bit

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2016 14:53:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3508aee88b8c4663386a5ffef0668cba41634a19
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

3508aee by Michael Mann (mmann78@xxxxxxxxxxxx):

    SMB: Limit Export object files to 32 bits.
    
    Most of the file offset fields are 32-bit, but the algorithms use gsize
    variables, which can vary between 32 and 64 bit builds.  The 64-bit
    builds are the ones with the problem with "garbage" data comes from
    (effectively) invalid 32-bit offsets.
    
    Bug: 11133
    Change-Id: Icb5d31ae732f9177f3a117dfae39bf1cc983d603
    Reviewed-on: https://code.wireshark.org/review/19090
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  af816dd   Bluetooth: BTLE*: Initialize what initialized was not
    adds  3508aee   SMB: Limit Export object files to 32 bits.


Summary of changes:
 ui/export_object_smb.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)