Wireshark-commits: [Wireshark-commits] master 83a1ab2: cmake: Fix building with plugins disabled

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2016 01:35:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83a1ab23abdb22ae7b84cff99009988f97fb3653
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

83a1ab2 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: Fix building with plugins disabled
    
    When Lua is enabled, scripts can still be loaded from the plugin dir
    (filesystem.c uses PLUGIN_INSTALL_DIR), so be sure to set it or the
    cmake build fails.
    
    Change-Id: I87d2d705434052220f9619438c90905c24b2a3a6
    Reviewed-on: https://code.wireshark.org/review/18976
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fca6bf6   Reflect API changes.
    adds  83a1ab2   cmake: Fix building with plugins disabled


Summary of changes:
 CMakeLists.txt |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)