Wireshark-commits: [Wireshark-commits] master cbf89c8: Check preference titles and descriptions.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 1 Dec 2016 01:27:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cbf89c8ed842a58c282872cf8c42adf9b8b2ffee
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cbf89c8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Check preference titles and descriptions.
    
    When registering preferences, make sure our titles and descriptions are
    valid UTF-8. Make sure our titles are short and only contain printable
    characters.
    
    Fix problematic titles and descriptions.
    
    Change-Id: I20d3f93438f2b3c30266f934297feb79897f2ee5
    Reviewed-on: https://code.wireshark.org/review/18998
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  9887cd7   Qt: fix crash when closing RTP player while playing
    adds  cbf89c8   Check preference titles and descriptions.


Summary of changes:
 epan/dissectors/asn1/snmp/packet-snmp-template.c |    2 +-
 epan/dissectors/packet-cp2179.c                  |    2 +-
 epan/dissectors/packet-diameter.c                |    2 +-
 epan/dissectors/packet-distcc.c                  |    2 +-
 epan/dissectors/packet-eth.c                     |    4 +--
 epan/dissectors/packet-ieee80211.c               |   19 +++++------
 epan/dissectors/packet-ipv6.c                    |    4 +--
 epan/dissectors/packet-iscsi.c                   |    2 +-
 epan/dissectors/packet-rpc.c                     |    2 +-
 epan/dissectors/packet-rtsp.c                    |    3 +-
 epan/dissectors/packet-smtp.c                    |    2 +-
 epan/dissectors/packet-snmp.c                    |    2 +-
 epan/prefs.c                                     |   39 ++++++++++++++++++----
 epan/prefs.h                                     |   10 +++++-
 14 files changed, 63 insertions(+), 32 deletions(-)