Wireshark-commits: [Wireshark-commits] master 0cb44e4: Handle FT_CHAR, and report unsupported types

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Nov 2016 03:18:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cb44e4277f3366234019c2f919ab1aea308822d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0cb44e4 by Guy Harris (guy@xxxxxxxxxxxx):

    Handle FT_CHAR, and report unsupported types as such.
    
    FT_CHAR is straightforward to support.
    
    Split the list of "invalid" types into a list of "unsupported" types and
    a short list of "invalid" types, containing FT_PCRE (which isn't a valid
    type for a field) and "everything else".  Add FT_IEEE_11073_SFLOAT and
    FT_IEEE_11073_FLOAT to the "unsupported" list.
    
    Flag the whole unsupported list as just "not handled yet".
    
    Change-Id: I62d2d7eead53377e4e601594a035b4395fdbeead
    Reviewed-on: https://code.wireshark.org/review/18979
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a222812   3GPP NAS: add an expert info when APN encoding exceeds 100 bytes
    adds  0cb44e4   Handle FT_CHAR, and report unsupported types as such.


Summary of changes:
 epan/wslua/wslua_proto_field.c |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)