Wireshark-commits: [Wireshark-commits] master b489b7f: lsd: fix unaligned read

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 10 Nov 2016 20:40:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b489b7ff7d4ba9f000f29c608515eb43059855ab
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b489b7f by Peter Wu (peter@xxxxxxxxxxxxx):

    lsd: fix unaligned read
    
    Fixes UBsan complaint:
    
        epan/dissectors/packet-lsd.c:141:7: runtime error: load of misaligned address 0x61d00017029e for type 'const guint32', which requires 4 byte alignment
    
    Change-Id: I74034f3e0bc198b4b86ca6cd7559d8df7283377f
    Reviewed-on: https://code.wireshark.org/review/18733
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ce98b6c   Enable exporting IMF traffic as an EML file
    adds  b489b7f   lsd: fix unaligned read


Summary of changes:
 epan/dissectors/packet-lsd.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)