URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e95d5fa8e2f7fec72f0d7350a0b07ca8cdfa12b
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
4e95d5f by Martin Kaiser (wireshark@xxxxxxxxx):
cmake: fix the linker flags test for Visual Studio
ddd1c87d43781533c3ec10279857e3870d12437e modified the order
of linker command line options. This broke the tests and made
invalid linker flags seem valid.
(Link target) ->
LINK : warning LNK4044: unrecognized option '/Wl,--as-needed'; ignored [C:\wireshark\build3\wsutil\wsutil.vcxproj]
LINK : warning LNK4044: unrecognized option '/pie'; ignored [C:\wireshark\build3\wsutil\wsutil.vcxproj]
The simple fix is to add specific options for Visual Studio and clang at the beginning of
the linker's command line options rather than at the end.
Change-Id: I6492ea1271e18be0d190e7579f47baecf6ac4d61
Reviewed-on: https://code.wireshark.org/review/18709
Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
Actions performed:
from 7531318 ERF: Fix issues with Host ID mapping
adds 4e95d5f cmake: fix the linker flags test for Visual Studio
Summary of changes:
cmake/modules/CheckCLinkerFlag.cmake | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)