Wireshark-commits: [Wireshark-commits] master ddd1c87: cmake: avoid leading space in linker options

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 7 Nov 2016 21:16:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddd1c87d43781533c3ec10279857e3870d12437e
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ddd1c87 by Martin Kaiser (wireshark@xxxxxxxxx):

    cmake: avoid leading space in linker options
    
    This causes problems with cmake 2.8.9, which ships with Debian Wheezy.
    
    Reorder the linker options to avoid a leading space. According to GNU
    ld's manual, the order of linker options on the command line does not
    matter. This should be the same for Visual Studio's cl.exe and for
    clang's linker.
    
    See
    https://www.wireshark.org/lists/wireshark-dev/201604/msg00141.html
    for more details about the problem.
    
    Change-Id: Ieaf7425600d394f365b01747747665233693fea2
    Reviewed-on: https://code.wireshark.org/review/18581
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  1b91475   JSON: print field value for an item containing a subtree
    adds  ddd1c87   cmake: avoid leading space in linker options


Summary of changes:
 cmake/modules/CheckCLinkerFlag.cmake |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)