Wireshark-commits: [Wireshark-commits] master da7354a: Fragmentation reassembly as in PPP MP (RFC 1

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Nov 2016 05:08:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da7354a6368fd72dcb58410d8572c061884045fc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

da7354a by John A. Thacker (johnthacker@xxxxxxxxx):

    Fragmentation reassembly as in PPP MP (RFC 1990/2686)
    
    Add support for defragmentation of fragments that use the defragmentation
    scheme of PPP MP (RFC 1990). Instead of getting "sequence_number,
    fragment_number, last" as in other protocols, PPP MP provides a single
    sequence number that is effectively "seqnum + fragnum", though it provides
    flags for both the first and last fragment of a reassembly.
    
    See Appendix A of RFC 4623 (PWE3 Fragmentation and Reassembly) for a list
    of protocols that use this style, including PPP MP (RFC 1990), PWE3 MPLS
    (RFC 4385), L2TPv2 (RFC 2661), L2TPv3 (RFC 3931), ATM, and Frame Relay.
    
    Also add support for the Multi-class Extension to Multilink PPP (RFC 2686),
    which uses some of the previously reserved bits as classes that distinguish
    otherwise identical sequence numbers.
    
    Bug: 12548
    Change-Id: Ic2ce3c50e61ab2eb50e4d92fd353ca4d2a48fe18
    Reviewed-on: https://code.wireshark.org/review/16327
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8ea8cb6   packet-bthci_cmd.c: Fix typos found by lintian.
    adds  da7354a   Fragmentation reassembly as in PPP MP (RFC 1990/2686)


Summary of changes:
 debian/libwireshark0.symbols |    2 +
 epan/dissectors/packet-ppp.c |  202 ++++++++++++++++++++---
 epan/reassemble.c            |  361 ++++++++++++++++++++++++++++++++++++++++++
 epan/reassemble.h            |   36 +++++
 epan/reassemble_test.c       |   28 ++--
 5 files changed, 592 insertions(+), 37 deletions(-)