Wireshark-commits: [Wireshark-commits] master 706c106: Have the routine that handles dissection opt

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 31 Oct 2016 00:38:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=706c10663499b90639ab8e46e171c4d4952778bf
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

706c106 by Guy Harris (guy@xxxxxxxxxxxx):

    Have the routine that handles dissection options not exit.
    
    Have it return TRUE if the option is OK and FALSE if it isn't, and let
    its caller exit as appropriate.
    
    Also, rename it - it's not adding something to a collection, it's just
    handling the option.
    
    Change-Id: I41863cbb67b7c257d900d3011609891b9b4a7467
    Reviewed-on: https://code.wireshark.org/review/18587
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  45a023f   Don't use proto_tree_add_{uint,uint64}() to add signed integer values.
    adds  706c106   Have the routine that handles dissection options not exit.


Summary of changes:
 tshark.c          |    3 ++-
 ui/commandline.c  |    3 ++-
 ui/dissect_opts.c |    9 +++++----
 ui/dissect_opts.h |   10 +++++++---
 4 files changed, 16 insertions(+), 9 deletions(-)