URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac4679ab5379e970c1dd329a969a3532bf9fced2
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
ac4679a by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: fix possible crash on sorting custom columns
The sorting function must maintain a strict weak ordering, otherwise it
may result in crashes. In the case of custom columns, this was violated
when exactly one of the two rows had a non-numeric value.
Bug: 13023
Change-Id: Ie338b1cce5156eeb313dd33491ee3d3f2eaddf1c
Reviewed-on: https://code.wireshark.org/review/18406
Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
Tested-by: Jim Young <jim.young.ws@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 3b502c873f2b30e661d46693d3a3f6fcba9474ea)
Reviewed-on: https://code.wireshark.org/review/18430
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from 1829c49 ZigBee Green Power: fix loading of keys during runtime
adds ac4679a Qt: fix possible crash on sorting custom columns
Summary of changes:
ui/qt/packet_list_model.cpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)