URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3156980aa559186a10e3b8566d41e4a50477d967
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3156980 by Parav Pandit (paravpandit@xxxxxxxxx):
packet-infiniband: Fixed displaying reserved field
1. Added Extended transport type field instead of reserved as per latest
release 1.3.1 in CM Req msg.
2. Defined reserved bits and bytes for CM messages
3. Minor code refactor to move to smaller functions for CM Req Rsp
parsing instead of 200+ lines function which is hard to read and
is expected to grow for more features
4. Cleanup around primary and alternate fields which were crossing byte
boundary
CM request and response messages are tested.
Reject message reserved fields change is untested but it a minor change
that is expected to work.
Change-Id: I94da62614f854218249b4e14c780f4168f44751c
Reported-by: Alexis La Goutte
Tested-by: paravpandit@xxxxxxxxx
Reviewed-on: https://code.wireshark.org/review/18340
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Actions performed:
from 875b3e2 ZigBee: fix the first parameter of memcpy
adds 3156980 packet-infiniband: Fixed displaying reserved field
Summary of changes:
epan/dissectors/packet-infiniband.c | 526 ++++++++++++++++++++---------------
1 file changed, 306 insertions(+), 220 deletions(-)