Wireshark-commits: [Wireshark-commits] master-2.0 17b9680: gmtime() can return NULL, even if it's u

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Oct 2016 22:51:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17b9680fff5d7aaade2e22f88312d7554b90c581
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

17b9680 by Guy Harris (guy@xxxxxxxxxxxx):

    gmtime() can return NULL, even if it's unlikely.
    
    ANSI C says it can return NULL - and, at least on Windows with the MSVC
    library, it *will* return null for dates prior to the Epoch.  Check for
    a null return and handle it.
    
    Fixes CID 1374110.
    
    Change-Id: I78bf92cfbb94a86544442269cc3b53338eb19778
    Reviewed-on: https://code.wireshark.org/review/18361
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 362b83f44a4a6a731c64f8a6591ee717af2454a0)
    Reviewed-on: https://code.wireshark.org/review/18363
    

Actions performed:

    from  250394b   Skype: Remove TCP heuristic dissection
    adds  17b9680   gmtime() can return NULL, even if it's unlikely.


Summary of changes:
 epan/dissectors/packet-cip.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)