Wireshark-commits: [Wireshark-commits] master-2.2 198fdae: Skype: Remove TCP heuristic dissection

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Oct 2016 01:02:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=198fdae316e0aa27f8568f3bf523dd523de43dee
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

198fdae by Michael Mann (mmann78@xxxxxxxxxxxx):

    Skype: Remove TCP heuristic dissection
    
    It was taking any/all TCP packets.
    
    Also clean up a little of the UDP heuristic.
    
    Change-Id: Iae08e79c0d71e4676cfc7821372ab9581c1d1cfc
    Ping-Bug: 13029
    Reviewed-on: https://code.wireshark.org/review/18322
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 404c31492be8b01d1b6bf9944ea3bb71feb92dd6)
    Reviewed-on: https://code.wireshark.org/review/18328
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5d6be2c   e212: Fix for e212.*.mnc
    adds  198fdae   Skype: Remove TCP heuristic dissection


Summary of changes:
 epan/dissectors/packet-skype.c |   37 ++++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 19 deletions(-)