[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2eb7b05 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Convert most UDP dissectors to use "auto" preferences.
    
    Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67,
    convert dissectors that use "udp.port".
    
    More cleanup done on dissectors that use both TCP and UDP dissector
    tables, so that less preference callbacks exist.
    
    Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3
    Reviewed-on: https://code.wireshark.org/review/18120
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4d8581d   CIP: Improve string handling
    adds  2eb7b05   Convert most UDP dissectors to use "auto" preferences.


Summary of changes:
 epan/dissectors/asn1/c1222/packet-c1222-template.c |    3 +-
 epan/dissectors/asn1/h225/packet-h225-template.c   |    6 +-
 epan/dissectors/asn1/h245/packet-h245-template.c   |    2 +-
 epan/dissectors/asn1/h248/packet-h248-template.c   |   32 +----
 epan/dissectors/asn1/h283/packet-h283-template.c   |    2 +-
 epan/dissectors/asn1/h501/packet-h501-template.c   |   32 ++---
 .../asn1/kerberos/packet-kerberos-template.c       |    2 +-
 epan/dissectors/asn1/ldap/packet-ldap-template.c   |    2 +-
 .../asn1/lte-rrc/packet-lte-rrc-template.c         |    2 +-
 epan/dissectors/asn1/sabp/packet-sabp-template.c   |    2 +-
 epan/dissectors/asn1/snmp/packet-snmp-template.c   |    6 +-
 epan/dissectors/asn1/t38/packet-t38-template.c     |    1 -
 epan/dissectors/asn1/tetra/packet-tetra-template.c |   11 +-
 epan/dissectors/asn1/ulp/packet-ulp-template.c     |   25 +---
 epan/dissectors/packet-3com-njack.c                |    4 +-
 epan/dissectors/packet-3g-a11.c                    |    4 +-
 epan/dissectors/packet-a21.c                       |   36 +----
 epan/dissectors/packet-acn.c                       |    2 +-
 epan/dissectors/packet-actrace.c                   |   39 +-----
 epan/dissectors/packet-adwin.c                     |   29 +---
 epan/dissectors/packet-aeron.c                     |    2 +-
 epan/dissectors/packet-alljoyn.c                   |   22 ++-
 epan/dissectors/packet-amr.c                       |    2 +-
 epan/dissectors/packet-aodv.c                      |    2 +-
 epan/dissectors/packet-ar_drone.c                  |   45 +------
 epan/dissectors/packet-armagetronad.c              |    6 +-
 epan/dissectors/packet-artnet.c                    |    2 +-
 epan/dissectors/packet-aruba-adp.c                 |    4 +-
 epan/dissectors/packet-aruba-erm.c                 |   49 ++-----
 epan/dissectors/packet-aruba-papi.c                |    2 +-
 epan/dissectors/packet-asap.c                      |    2 +-
 epan/dissectors/packet-asterix.c                   |    2 +-
 epan/dissectors/packet-atalk.c                     |    2 +-
 epan/dissectors/packet-ath.c                       |    6 +-
 epan/dissectors/packet-auto_rp.c                   |   10 +-
 epan/dissectors/packet-ax4000.c                    |    6 +-
 epan/dissectors/packet-ayiya.c                     |    2 +-
 epan/dissectors/packet-babel.c                     |    6 +-
 epan/dissectors/packet-bat.c                       |   76 +++--------
 epan/dissectors/packet-bfcp.c                      |    2 +-
 epan/dissectors/packet-bfd.c                       |    6 +-
 epan/dissectors/packet-bjnp.c                      |   10 +-
 epan/dissectors/packet-bootp.c                     |    6 +-
 epan/dissectors/packet-brp.c                       |   34 +----
 epan/dissectors/packet-bt-dht.c                    |   20 +--
 epan/dissectors/packet-bt-utp.c                    |   22 +--
 epan/dissectors/packet-bvlc.c                      |   45 +------
 epan/dissectors/packet-c1222.c                     |    3 +-
 epan/dissectors/packet-capwap.c                    |   56 ++++----
 epan/dissectors/packet-cattp.c                     |   17 +--
 epan/dissectors/packet-ccsds.c                     |    2 +-
 epan/dissectors/packet-cfdp.c                      |    2 +-
 epan/dissectors/packet-chargen.c                   |    2 +-
 epan/dissectors/packet-cigi.c                      |    2 +-
 epan/dissectors/packet-cisco-marker.c              |    2 +-
 epan/dissectors/packet-cisco-wids.c                |   34 +----
 epan/dissectors/packet-classicstun.c               |    2 +-
 epan/dissectors/packet-cnip.c                      |    5 +-
 epan/dissectors/packet-coap.c                      |   31 +----
 epan/dissectors/packet-collectd.c                  |   42 +-----
 epan/dissectors/packet-componentstatus.c           |    4 +-
 epan/dissectors/packet-corosync-totemnet.c         |   35 ++---
 epan/dissectors/packet-cpfi.c                      |   16 +--
 epan/dissectors/packet-cpha.c                      |    5 +-
 epan/dissectors/packet-cups.c                      |    6 +-
 epan/dissectors/packet-daytime.c                   |    2 +-
 epan/dissectors/packet-db-lsp.c                    |    2 +-
 epan/dissectors/packet-ddtp.c                      |    5 +-
 epan/dissectors/packet-dhcpv6.c                    |    9 +-
 epan/dissectors/packet-diameter.c                  |   19 +--
 epan/dissectors/packet-dis.c                       |   37 +----
 epan/dissectors/packet-dlsw.c                      |    2 +-
 epan/dissectors/packet-dmp.c                       |   28 +---
 epan/dissectors/packet-dnp.c                       |    2 +-
 epan/dissectors/packet-dns.c                       |   31 +----
 epan/dissectors/packet-dof.c                       |    6 +-
 epan/dissectors/packet-dtn.c                       |   28 +---
 epan/dissectors/packet-dvb-ipdc.c                  |    2 +-
 epan/dissectors/packet-echo.c                      |    2 +-
 epan/dissectors/packet-ecmp.c                      |   19 +--
 epan/dissectors/packet-edonkey.c                   |    5 +-
 epan/dissectors/packet-egd.c                       |   10 +-
 epan/dissectors/packet-ehs.c                       |    2 +-
 epan/dissectors/packet-elasticsearch.c             |    4 +-
 epan/dissectors/packet-enip.c                      |    4 +-
 epan/dissectors/packet-enrp.c                      |    2 +-
 epan/dissectors/packet-enttec.c                    |   30 +----
 epan/dissectors/packet-epl.c                       |    2 +-
 epan/dissectors/packet-esio.c                      |    4 +-
 epan/dissectors/packet-eth.c                       |    2 +-
 epan/dissectors/packet-ff.c                        |   22 +--
 epan/dissectors/packet-ff.h                        |    5 +-
 epan/dissectors/packet-forces.c                    |   18 +--
 epan/dissectors/packet-geneve.c                    |    3 +-
 epan/dissectors/packet-glbp.c                      |    8 +-
... 203 lines suppressed ...