URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=40d23eb23a3e44dbf6554f3747c012333c710dec
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
40d23eb by D. Ulis (daulis0@xxxxxxxxx):
CIP: More minor bug fixes
1. CIP Safety: Exception Detail Alarm and Exception Detail Warning both were not parsing their 3 parts because the offset was not increased. Fixed the offsets and combined the functions because they have the same format.
2. CIP: Forward Open Safety Response had wrong offsets so it was parsing incorrectly. This incorrectly showed as Malformed.
3. CIP Safety: Pass in tvb to proto_tree_add_subtree() instead of NULL. This was causing a Dissector bug (seems only on trunk, not 2.2). This was already done for packet-cip.c under https://code.wireshark.org/review/#/c/16748/
4. Some minor typos
Change-Id: I63e8d200cd3408c16ca0a1edbc483c3bb8298d3b
Reviewed-on: https://code.wireshark.org/review/18100
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 8b6de4c Add a little more info about vagrant and our Vagrantfile.
adds 40d23eb CIP: More minor bug fixes
Summary of changes:
epan/dissectors/packet-cip.c | 4 +-
epan/dissectors/packet-cipsafety.c | 196 ++++++++++--------------------------
2 files changed, 56 insertions(+), 144 deletions(-)