Wireshark-commits: [Wireshark-commits] master-2.2 2bd456d: TCP: Fix next sequence number for SYN/FI

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Oct 2016 04:22:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2bd456df196b02e4f16d20bf7eb440ea46502c66
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2bd456d by Uli Heilmeier (uh@xxxxxxxxxxxx):

    TCP: Fix next sequence number for SYN/FIN packets with payload
    
    The next sequence number is off by one when there is TCP payload
    in a SYN or FIN packet (e.g. when using TCP FastOpen).
    
    Bug: 12579
    Bug: 12838
    Change-Id: Idb68cea4b4dcba39461019c08db09367cbfc6d68
    Reviewed-on: https://code.wireshark.org/review/16239
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 12d55fb917dad1aaba8429b24cb1eac49c3cd11f)
    Reviewed-on: https://code.wireshark.org/review/17975
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c95828d   EIGRP: fix checksum computation
    adds  2bd456d   TCP: Fix next sequence number for SYN/FIN packets with payload


Summary of changes:
 epan/dissectors/packet-tcp.c |   11 +++++++++++
 1 file changed, 11 insertions(+)